Skip to content

Prepare for lang FCPs in stdarch #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prepare for lang FCPs in stdarch #2007

wants to merge 1 commit into from

Conversation

traviscross
Copy link
Contributor

@traviscross traviscross commented Oct 1, 2025 •
edited
Loading

Increasingly, due to what lives in stdarch, there's the likelihood of the lang team needing to do FCPs there. Let's arrange for that.

cc @rust-lang/lang @sayantn rust-lang/rust#146560

See, e.g., rust-lang/rust#146560 (comment).

This blocks rust-lang/stdarch#1935.

@traviscross
Prepare for lang FCPs in stdarch
dbbb35e 
Increasingly, due to what lives in stdarch, there's the likelihood of
the lang team needing to do FCPs there.  Let's arrange for that.
@traviscross traviscross force-pushed the TC/prepare-for-lang-fcps-in-stdarch branch from d3aaf11 to dbbb35e Compare October 1, 2025 21:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025

Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/stdarch':
      Permission Changes:
        Giving team 'lang' write permission
        Giving team 'lang-ops' write permission
        Giving user 'rust-rfcbot' write permission

@jieyouxu jieyouxu added needs-infra-admin-review This change requires one of the `infra-admins` to review. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin. labels Oct 2, 2025
jieyouxu
jieyouxu approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

team-repo-admin approval given for team access changes, need an infra-admin approval for the bot changes.

nikomatsakis
nikomatsakis approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful. To be honest, I don't know why we do this on a repo-by-repo basis at all.

@traviscross traviscross mentioned this pull request Oct 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

+4 more reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

@joshtriplett joshtriplett joshtriplett approved these changes

@Amanieu Amanieu Amanieu approved these changes

@tmandry tmandry tmandry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-infra-admin-review This change requires one of the `infra-admins` to review. needs-team-repo-admin-review This change requires one of the `team-repo-admins` to review. S-waiting-on-review Status: waiting on review from a team/WG/PG lead, an infra-admin, and/or a team-repo-admin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@traviscross @nikomatsakis @joshtriplett @Amanieu @tmandry @jieyouxu